chore: Add upper bound to sidekiq instrumentation #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferenc G茅czi <ferenc.geczi@ibm.com>
basti1302
approved these changes
May 24, 2023
basti1302
reviewed
May 24, 2023
| @@ -5,7 +5,8 @@ module Instana | |||
| module Activators | |||
| class SidekiqClient < Activator | |||
| def can_instrument? | |||
| defined?(::Sidekiq) && ::Sidekiq.respond_to?(:configure_client) && ::Instana.config[:'sidekiq-client'][:enabled] | |||
| defined?(::Sidekiq) && defined?(::Sidekiq::VERSION) && ::Sidekiq.respond_to?(:configure_client) && ::Instana.config[:'sidekiq-client'][:enabled] && | |||
| Gem::Specification.find_by_name('sidekiq').version < Gem::Version.new('5.3') | |||
There was a problem hiding this comment.
question: Just out of curiosity: Do we ever log something if can_instrument? returns false? This is probably out of scope for this PR, but it might be valuable to log this at least at debug level.
Ferenc-
force-pushed
the
sidekiq-upper-bound
branch
from
9aeabff
to
874610f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.