Breaking change: stream() semantics when used with stateful generators
#869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ors.
With this commit, all root objects created by `stream()` are independent
of each other. This affects the behaviour of `stream()` when used with
stateful generators such as `emit()`, `intSeq()`, `longSeq()`.
Example:
```java
List<String> results = Instancio.of(String.class)
.generate(allStrings(), gen -> gen.emit().items("foo", "bar", "baz").ignoreUnused())
.stream()
.limit(3)
.toList();
// Original behaviour
assertThat(results).containsExactly("foo", "bar", "baz");
// New behaviour
assertThat(results).containsExactly("foo", "foo", "foo");
```
armandino
force-pushed
the
stream-changes
branch
from
bb02b81
to
c58493d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit, all root objects created by
stream()are independent of each other. This affects the behaviour ofstream()when used with stateful generators such asemit(),intSeq(),longSeq().Example: