Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement hideSliders TriangleColorPicker #10

Merged
merged 1 commit into from
Aug 15, 2020
Merged

Implement hideSliders TriangleColorPicker #10

merged 1 commit into from
Aug 15, 2020

Conversation

afreeland
Copy link
Contributor

No description provided.

@sodik82
Copy link
Contributor

sodik82 commented Feb 24, 2019

thanks for your PR. The property name hideSliders does not match the "reality" for triangle picker. If we want to unify the interface - something like hideControls should be better name for both components. And pls update also documentation.

@sodik82 sodik82 merged commit efa430f into instea:master Aug 15, 2020
@sodik82 sodik82 mentioned this pull request Aug 15, 2020
Closed
@dmko1610 dmko1610 mentioned this pull request Aug 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@afreeland @sodik82