CI on Github Actions #719
CI on Github Actions #719
Conversation
Update APT's sources with the new archived URL
Also, stop sharing the host's `lein` directory, and set the platform to be AMD64-only - we don't support ARM yet.
The previous version relied in external scripts having already built the correct version of the binaries. Now running `docker build` should be enough to properly build an image of the app. There are optimisations to apply, for sure.
matiasgarciaisaia
force-pushed
the
preview/github-action
branch
from
da0fe48
to
4e819e0
Compare
matiasgarciaisaia
force-pushed
the
preview/github-action
branch
from
4e819e0
to
69f2f15
Compare
Thanks for all the fish, CircleCI!
matiasgarciaisaia
force-pushed
the
preview/github-action
branch
from
69f2f15
to
034b3c2
Compare
| dockerBuildAndPush -d mapserver -s "-mapserver" -t "-mapserver" -o "-f mapserver/Dockerfile.mapserver" | ||
| dockerBuildAndPush -d mapserver -s "-mapserver" -t "-mapcache" -o "-f mapserver/Dockerfile.mapcache" |
There was a problem hiding this comment.
Does it make sense to add the tag suffix as well as the image suffix?
| @@ -2,9 +2,6 @@ version: '2' | |||
|
|
|||
| services: | |||
| app: | |||
| volumes: | |||
| - .:/app | |||
| - ~/cache/.m2:/root/.m2 | |||
There was a problem hiding this comment.
The Maven cache would be good to restore at some point. The overhead of downloading the same dependencies over and over is high.
There was a problem hiding this comment.
I think we should eventually split the image in two - one with the base dependencies, and the other one with that PLUS the app's code.
| MAPCACHE_TAG=instedd/planwise-mapserver:mapcache-$TAG | ||
| MAPSERVER_TAG=instedd/planwise-mapserver:mapserver-$TAG |
There was a problem hiding this comment.
Oh, I see why you added the tag suffix above. I think in this case the TAG was not meant to be a versioning tag, but a content tag. Ie. at some point we would generate the mapserver image with some regional TIFFs included. But I don't think we've used them in that way for a very long time.
There was a problem hiding this comment.
Interesting.
I see in Docker Hub we have some tag kenya-mapserver-stable, but I also see mapcache-latest, mapcache-master & mapcache-stable (created a few years ago).
I mean, I really am not sure about what these things are or do, so I'll trust your judgment here. I'm just replicating the CI we had.
There was a problem hiding this comment.
Oh, wait. I didn't realize that we didn't have a different repo for mapcache. That's what the tag is being used for. I'd go for a different Docker repo though.
There was a problem hiding this comment.
Agree on that. I'll leave that for later, though.
This PR moves the CI from CircleCI to Github Actions.
The only breaking change we introduce is that the
instedd/planwise-mapserverimages are now taggedVERSION-mapserverandVERSION-mapcacheinstead ofmapcache-VERSIONlike before.