Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add contribution guide #106

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

jvallesm
Copy link
Collaborator

@jvallesm jvallesm commented Apr 26, 2024

Because

  • We need a guide to onboard newcomers and external contributors to add new components.

This commit

  • Fixes outdated documentation in the contribution guidelines.
  • Adds a section with the steps to add a hello, world! component.

@jvallesm jvallesm self-assigned this Apr 26, 2024
Copy link

linear bot commented Apr 26, 2024

@jvallesm jvallesm force-pushed the jvalles/ins-4323-component-contribution-guide branch 6 times, most recently from a2e9094 to b01611e Compare April 26, 2024 06:55
- Start / End operator -> Trigger / Response
- Connector configuration (secrets)
- Recipe
- Trigger
@jvallesm jvallesm force-pushed the jvalles/ins-4323-component-contribution-guide branch 4 times, most recently from c3dbe60 to 7144516 Compare April 26, 2024 16:16
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.98%. Comparing base (4ce9851) to head (7144516).
Report is 15 commits behind head on main.

❗ Current head 7144516 differs from pull request most recent head baa4eea. Consider uploading reports for the commit baa4eea to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   57.32%   57.98%   +0.65%     
==========================================
  Files          30       30              
  Lines        3145     3063      -82     
==========================================
- Hits         1803     1776      -27     
+ Misses       1104     1049      -55     
  Partials      238      238              
Flag Coverage Δ
unittests 57.98% <ø> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jvallesm jvallesm force-pushed the jvalles/ins-4323-component-contribution-guide branch from 7144516 to baa4eea Compare April 26, 2024 16:23
@jvallesm jvallesm marked this pull request as ready for review April 26, 2024 16:27
@jvallesm jvallesm changed the title fix: update documentation feat: add contribution guide Apr 27, 2024
Copy link
Member

@donch1989 donch1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great!

@jvallesm jvallesm merged commit 3957579 into main Apr 29, 2024
8 checks passed
@jvallesm jvallesm deleted the jvalles/ins-4323-component-contribution-guide branch April 29, 2024 05:06
donch1989 pushed a commit that referenced this pull request May 7, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.16.0-beta](v0.15.0-beta...v0.16.0-beta)
(2024-04-30)


### Features

* add contribution guide
([#106](#106))
([3957579](3957579))


### Bug Fixes

* typos in contribution guide
([#108](#108))
([f01c049](f01c049))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👋 Done
3 participants