Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(component): refactor instillFormat xxx_array to array #22

Merged

Conversation

donch1989
Copy link
Member

Because

  • we should use instillFormat: array to simplify the json-schema structure

This commit

  • refactor instillFormat: xxx_array to array

Copy link

linear bot commented Nov 1, 2023

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bafafe9) 76.49% compared to head (a2c6532) 76.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   76.49%   76.49%           
=======================================
  Files           1        1           
  Lines         217      217           
=======================================
  Hits          166      166           
  Misses         34       34           
  Partials       17       17           
Flag Coverage Δ
unittests 76.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donch1989 donch1989 merged commit 0bcb5ec into main Nov 1, 2023
9 checks passed
@donch1989 donch1989 deleted the huitang/ins-2492-refactor-instillformat-xxx_array-to-array branch November 1, 2023 06:57
namwoam pushed a commit to namwoam/component that referenced this pull request Jun 24, 2024
…ll-ai#22)

Because

- we should use `instillFormat: array` to simplify the json-schema
structure

This commit

- refactor `instillFormat: xxx_array` to `array`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
2 participants