fix(connector): fix credentialFields bug inside oneOf schema
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
=======================================
Coverage 76.49% 76.49%
=======================================
Files 1 1
Lines 217 217
=======================================
Hits 166 166
Misses 34 34
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jvallesm
pushed a commit
that referenced
this pull request
Jan 15, 2024
🤖 I have created a release *beep* *boop* --- ## [0.9.0-beta](v0.8.0-beta...v0.9.0-beta) (2024-01-12) ### Features * add `instillUpstreamTypes: template` in component condition field ([#46](#46)) ([60b2117](60b2117)) * **schema:** add new instillFormat for chat history ([#43](#43)) ([abed794](abed794)) * update GetOperatorDefinition functions to support dynamic definition ([#47](#47)) ([792559e](792559e)) ### Bug Fixes * **connector:** fix credentialFields bug inside `oneOf` schema ([#45](#45)) ([eb76043](eb76043)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
namwoam
pushed a commit
to namwoam/component
that referenced
this pull request
Jun 24, 2024
namwoam
pushed a commit
to namwoam/component
that referenced
this pull request
Jun 24, 2024
🤖 I have created a release *beep* *boop* --- ## [0.9.0-beta](instill-ai/component@v0.8.0-beta...v0.9.0-beta) (2024-01-12) ### Features * add `instillUpstreamTypes: template` in component condition field ([instill-ai#46](instill-ai#46)) ([60b2117](instill-ai@60b2117)) * **schema:** add new instillFormat for chat history ([instill-ai#43](instill-ai#43)) ([abed794](instill-ai@abed794)) * update GetOperatorDefinition functions to support dynamic definition ([instill-ai#47](instill-ai#47)) ([792559e](instill-ai@792559e)) ### Bug Fixes * **connector:** fix credentialFields bug inside `oneOf` schema ([instill-ai#45](instill-ai#45)) ([eb76043](instill-ai@eb76043)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
credentialFieldsdoes not work inside theoneOfJSON schema.This commit
credentialFieldsbug inside theoneOfJSON schema.