Skip to content

Commit

Permalink
feat: update model task label (#347)
Browse files Browse the repository at this point in the history
Because

- We have new model task

This commit

- update model task label
- Make all fields to have normal label instead of inset label
  • Loading branch information
EiffelFly committed Feb 17, 2023
1 parent 01c8c41 commit bb317f1
Show file tree
Hide file tree
Showing 15 changed files with 167 additions and 99 deletions.
8 changes: 6 additions & 2 deletions integration-test/destination-async.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
import { env , deleteDestination, expectToSelectReactSelectOption } from "./helper";
import {
env,
deleteDestination,
expectToSelectReactSelectOption,
} from "./helper";
import { test, expect } from "@playwright/test";
import { expectToDeleteConnector } from "./common/connector";

Expand Down Expand Up @@ -46,7 +50,7 @@ test.describe.serial("Async destination", () => {
// Should have warning label
const warningLabel = page.locator("label[for='id']");
await expect(warningLabel).toHaveText(
"ID * - Resource ID restricts to lowercase letters, numbers, and hyphen, with the first character a letter, the last a letter or a number, and a 63 character maximum."
"ID *Resource ID restricts to lowercase letters, numbers, and hyphen, with the first character a letter, the last a letter or a number, and a 63 character maximum."
);
});

Expand Down
2 changes: 1 addition & 1 deletion integration-test/model-artivc.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ test.describe.serial("Artivc model", () => {
"#react-select-modelInstanceTag-option-0"
),
modelState: "STATE_ONLINE",
modelTask: "CLASSIFICATION",
modelTask: "Classification",
additionalRules: async () => {
// Should have correct artivc version/model instance tag
const artivcVersionField = page.locator("input#tag");
Expand Down
2 changes: 1 addition & 1 deletion integration-test/model-general.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ test.describe.serial("Create model", () => {
// Should have warning label
const warningLabel = page.locator("label[for='modelId']");
await expect(warningLabel).toHaveText(
"ID * - Resource ID restricts to lowercase letters, numbers, and hyphen, with the first character a letter, the last a letter or a number, and a 63 character maximum."
"ID *Resource ID restricts to lowercase letters, numbers, and hyphen, with the first character a letter, the last a letter or a number, and a 63 character maximum."
);
});
});
2 changes: 1 addition & 1 deletion integration-test/model-github.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ test.describe.serial("GitHub model", () => {
"#react-select-modelInstanceTag-option-1"
),
modelState: "STATE_ONLINE",
modelTask: "CLASSIFICATION",
modelTask: "Classification",
});
});

Expand Down
2 changes: 1 addition & 1 deletion integration-test/model-huggingface.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ test.describe.serial("Hugging face model", () => {
"#react-select-modelInstanceTag-option-0"
),
modelState: "STATE_ONLINE",
modelTask: "CLASSIFICATION",
modelTask: "Classification",
additionalRules: async () => {
const huggingFaceModelIdField = page.locator(
"input#huggingface-model-id"
Expand Down
2 changes: 1 addition & 1 deletion integration-test/model-local.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ test.describe.serial("Local model", () => {
"#react-select-modelInstanceTag-option-0"
),
modelState: "STATE_ONLINE",
modelTask: "CLASSIFICATION",
modelTask: "Classification",
});
});

Expand Down
5 changes: 3 additions & 2 deletions integration-test/pipeline-sync.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { env ,
import {
env,
deleteDestination,
deleteModel,
deleteSource,
Expand Down Expand Up @@ -152,7 +153,7 @@ test.describe
// Should have warning label
const warningLabel = page.locator("label[for='pipelineId']");
await expect(warningLabel).toHaveText(
"ID * - Resource ID restricts to lowercase letters, numbers, and hyphen, with the first character a letter, the last a letter or a number, and a 63 character maximum."
"ID *Resource ID restricts to lowercase letters, numbers, and hyphen, with the first character a letter, the last a letter or a number, and a 63 character maximum."
);

// Should input correct id
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"dependencies": {
"@amplitude/analytics-browser": "^0.4.1",
"@code-hike/mdx": "^0.7.3",
"@instill-ai/design-system": "^0.0.136",
"@instill-ai/design-system": "^0.0.146",
"axios": "^0.27.2",
"clsx": "^1.1.1",
"cookie": "^0.5.0",
Expand Down
2 changes: 1 addition & 1 deletion playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const config: PlaywrightTestConfig = {
// baseURL: 'http://localhost:3000',

/* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */
trace: "on-first-retry",
trace: process.env.CI ? "off" : "on-first-retry",
baseURL: process.env.NEXT_PUBLIC_CONSOLE_BASE_URL,

// Because our backend is served with self-signed certification, we have to
Expand Down

0 comments on commit bb317f1

Please sign in to comment.