Skip to content

Commit

Permalink
feat: unify the gap between elements in every table (#291)
Browse files Browse the repository at this point in the history
Related issue - #288. Our elements in every table are not consistent. This PR fixes this issue. (close #288)
  • Loading branch information
EiffelFly committed Oct 3, 2022
1 parent 76a6f99 commit e743820
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const ConnectionTypeCell = ({
return (
<CellBase padding={padding}>
<div className={cn("py-2.5", width)}>
<div className="flex flex-row gap-x-2.5">
<div className="flex flex-row gap-x-[5px]">
<Image
className="my-auto"
src={
Expand All @@ -33,8 +33,8 @@ const ConnectionTypeCell = ({
? `/icons/airbyte/${connectorDefinition.connector_definition.icon}`
: `/icons/instill/${connectorDefinition.connector_definition.icon}`
}
width={32}
height={32}
width={30}
height={30}
layout="fixed"
/>
<p
Expand Down
4 changes: 2 additions & 2 deletions src/components/ui/TableCells/InstanceCell/InstanceCell.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ const InstanceCell: FC<InstanceCellProps> = ({
"gap-y-3": instances.length > 0,
})}
>
<div className="flex flex-row gap-x-3">
<div className="flex flex-row gap-x-[5px]">
{icon}
<p className="text-instillGrey90 text-instill-body">
<p className="my-auto text-instillGrey90 text-instill-body">
{instances ? instances.length : 0}
</p>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/ui/TableCells/ModeCell/ModeCell.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const ModeCell: FC<ModeCellProps> = ({ width, mode, padding }) => {

return (
<CellBase padding={padding}>
<div className={cn("flex gap-x-2 mr-auto", width)}>
<div className={cn("flex gap-x-[5px] mr-auto", width)}>
{modeIcon}
<p className="text-instillGrey90 text-instill-body">
{mode === "MODE_ASYNC" ? "Async" : "Sync"}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ const ModelDefintionCell: FC<ModelDefintionCellProps> = ({

return (
<CellBase padding={padding}>
<div className={cn("flex flex-row gap-x-2", width)}>
<div className={cn("flex flex-row gap-x-[5px]", width)}>
{definitionIcon}
<p className="my-auto flex text-instillGrey90 text-instill-body">
{definitionLabel}
Expand Down
4 changes: 2 additions & 2 deletions src/components/ui/TableCells/ModelsCell/ModelsCell.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ const ModelsCell: FC<ModelsCellProps> = ({
<div key={key} className="flex flex-col gap-y-2">
<div className="flex flex-row gap-x-1">
<ModelInstanceIcon
width="w-5"
height="h-5"
width="w-[30px]"
height="h-[30px]"
color="fill-black"
position="my-auto"
/>
Expand Down

0 comments on commit e743820

Please sign in to comment.