Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix change resource button is not disabled when we need to #369

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

EiffelFly
Copy link
Member

Because

  • when NEXT_PUBLIC_DISABLE_CREATE_UPDATE_DELETE_RESOURCE=true we need to disable all related action

This commit

  • fix change resource button is not disabled when we need to

@EiffelFly EiffelFly merged commit 53f5472 into main Mar 7, 2023
@EiffelFly EiffelFly deleted the disable-state-toggle-when-we-need-to branch March 7, 2023 01:55
pinglin added a commit that referenced this pull request Mar 26, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.20.0-alpha](v0.19.0-alpha...v0.20.0-alpha)
(2023-03-26)


### Features

* [INS-250] update the logic of tracking cookie
([#372](#372))
([4a828e9](4a828e9))
* [INS-267] mock onboarded cookie
([#378](#378))
([bbf8322](bbf8322))
* add playwright state
([#373](#373))
([b1ff209](b1ff209))
* Impl pagination
([#365](#365))
([6db8461](6db8461))
* make test operate in order and bump playwright version
([#374](#374))
([ddfcd5a](ddfcd5a))
* update how we store playwright state
([#376](#376))
([9bf8de5](9bf8de5))


### Bug Fixes

* don't specific domain when set cookie
([#377](#377))
([109a5f9](109a5f9))
* fix change resource button is not disabled when we need to
([#369](#369))
([53f5472](53f5472))
* fix import path in test
([#379](#379))
([7463895](7463895))
* fix pipelines table margin bottom issue
([#367](#367))
([99776bd](99776bd))
* fix playwright container version
([#375](#375))
([bf4924c](bf4924c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Ping-Lin Chang <ping-lin.chang@instill.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant