fix: don't specific domain when set cookie #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EiffelFly
requested review from
pinglin,
Phelan164 and
xiaofei-du
as code owners
This was referenced Mar 22, 2023
pinglin
added a commit
that referenced
this pull request
Mar 26, 2023
🤖 I have created a release *beep* *boop* --- ## [0.20.0-alpha](v0.19.0-alpha...v0.20.0-alpha) (2023-03-26) ### Features * [INS-250] update the logic of tracking cookie ([#372](#372)) ([4a828e9](4a828e9)) * [INS-267] mock onboarded cookie ([#378](#378)) ([bbf8322](bbf8322)) * add playwright state ([#373](#373)) ([b1ff209](b1ff209)) * Impl pagination ([#365](#365)) ([6db8461](6db8461)) * make test operate in order and bump playwright version ([#374](#374)) ([ddfcd5a](ddfcd5a)) * update how we store playwright state ([#376](#376)) ([9bf8de5](9bf8de5)) ### Bug Fixes * don't specific domain when set cookie ([#377](#377)) ([109a5f9](109a5f9)) * fix change resource button is not disabled when we need to ([#369](#369)) ([53f5472](53f5472)) * fix import path in test ([#379](#379)) ([7463895](7463895)) * fix pipelines table margin bottom issue ([#367](#367)) ([99776bd](99776bd)) * fix playwright container version ([#375](#375)) ([bf4924c](bf4924c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Ping-Lin Chang <ping-lin.chang@instill.tech>
This was referenced Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit