Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix import path in test #379

Merged
merged 2 commits into from
Mar 22, 2023
Merged

fix: fix import path in test #379

merged 2 commits into from
Mar 22, 2023

Conversation

EiffelFly
Copy link
Member

Because

  • the env import path is wrong

This commit

  • fix import path in test
  • Add vim into playwright container

@EiffelFly EiffelFly merged commit 7463895 into main Mar 22, 2023
@EiffelFly EiffelFly deleted the fix-import-path-in-test branch March 22, 2023 05:53
This was referenced Mar 22, 2023
Closed
Merged
pinglin added a commit that referenced this pull request Mar 26, 2023
@droplet-bot @pinglin
chore(main): release 0.20.0-alpha (#383)
3b5b534 
🤖 I have created a release *beep* *boop*
---


##
[0.20.0-alpha](v0.19.0-alpha...v0.20.0-alpha)
(2023-03-26)


### Features

* [INS-250] update the logic of tracking cookie
([#372](#372))
([4a828e9](4a828e9))
* [INS-267] mock onboarded cookie
([#378](#378))
([bbf8322](bbf8322))
* add playwright state
([#373](#373))
([b1ff209](b1ff209))
* Impl pagination
([#365](#365))
([6db8461](6db8461))
* make test operate in order and bump playwright version
([#374](#374))
([ddfcd5a](ddfcd5a))
* update how we store playwright state
([#376](#376))
([9bf8de5](9bf8de5))


### Bug Fixes

* don't specific domain when set cookie
([#377](#377))
([109a5f9](109a5f9))
* fix change resource button is not disabled when we need to
([#369](#369))
([53f5472](53f5472))
* fix import path in test
([#379](#379))
([7463895](7463895))
* fix pipelines table margin bottom issue
([#367](#367))
([99776bd](99776bd))
* fix playwright container version
([#375](#375))
([bf4924c](bf4924c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Ping-Lin Chang <ping-lin.chang@instill.tech>
This was referenced Apr 10, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@Phelan164 Phelan164 Awaiting requested review from Phelan164

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@EiffelFly