Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add the missing return button in the subscription form (They are already in the design handover) #932

Merged
merged 1 commit into from
Feb 7, 2024
Merged

chore: add the missing return button in the subscription form (They are already in the design handover) #932

merged 1 commit into from
Feb 7, 2024

Conversation

iamnamananand996
Copy link
Contributor

@iamnamananand996 iamnamananand996 commented Feb 1, 2024 •
edited
Loading

Because

  • update BreadcrumbWithLink

This commit

  • update BreadcrumbWithLink

@linear Linear
Copy link

linear bot commented Feb 1, 2024

INS-2915 Add the missing return button in the subscription form (They are already in the design handover)

@vercel Vercel
Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
instill-form-playground ✅ Ready (Inspect) Visit Preview Feb 1, 2024 9:31pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@EiffelFly
Copy link
Member

EiffelFly commented Feb 2, 2024 •
edited
Loading

@iamnamananand996 This issue is about the subscription flow. There is a back to previous step breadcrum like button and I miss that.

CleanShot 2024-02-02 at 16 23 17

Here is the figma link https://www.figma.com/file/RWamQ8SHVd2oyqQE1uvbDW/Team-%2F-Organisation?type=design&node-id=588-54894&mode=design&t=4CTSGRbtaDFbCYBd-4

Please also update the PR title

@iamnamananand996 iamnamananand996 changed the title chore: update BreadcrumbWithLink chore: add the missing return button in the subscription form (They are already in the design handover) Feb 2, 2024
@iamnamananand996
Copy link
Contributor Author

Hi @EiffelFly, updated suggested changes here

EiffelFly
EiffelFly approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@EiffelFly EiffelFly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EiffelFly EiffelFly merged commit 03ef163 into main Feb 7, 2024
14 checks passed
@EiffelFly EiffelFly deleted the namananand/ins-2915-add-the-missing-return-button-in-the-subscription-form-they branch February 7, 2024 12:16
@droplet-bot droplet-bot mentioned this pull request Feb 7, 2024
Merged
EiffelFly pushed a commit that referenced this pull request Feb 16, 2024
@droplet-bot
chore: release main (#933)
f44b0ba 
🤖 I have created a release *beep* *boop*
---


<details><summary>0.39.0-beta</summary>

##
[0.39.0-beta](v0.38.0-beta...v0.39.0-beta)
(2024-02-15)


### Features

* adapt new backend breaking changes about mgmt backend
([#940](#940))
([3351262](3351262))
* add SubscriptionStatus to sdk
([#964](#964))
([f5e67ba](f5e67ba))
* add trial_end field into StripeSubscriptionDetail
([#965](#965))
([7b7324b](7b7324b))
* **auto-gen-form:** handle Airbyte form and instill data form
separately ([#956](#956))
([23ce0eb](23ce0eb))
* **pipeline-builder:** copy & paste full reference with ${} instead of
path only ([#967](#967))
([231ac2f](231ac2f))
* **pipeline-builder:** implement the layered flow of smart hint
([#934](#934))
([69dc912](69dc912))
* **pipeline-builder:** implement the new array data type label design
([#957](#957))
([0c6ef4e](0c6ef4e))
* **pipeline-builder:** replace semi-structured/object with
semi-structured/json on start operator
([#954](#954))
([df71434](df71434))
* **pipeline-builder:** support hinting other type that can be
stringified ([#949](#949))
([c0c8892](c0c8892))
* **pipeline-builder:** support video/multiple-video in pipeline builder
([#943](#943))
([2680f70](2680f70))
* **pipeline-builder:** unify the onEdit and onDelete item on both start
and end operator
([#936](#936))
([d70120f](d70120f))
* **instill-hub:** User can reset visibility filter to display all
pipelines ([#947](#947))
([1ba36a0](1ba36a0))
* **instill-hub:** User can switch between different version on pipeline
details page([#942](#942))
([a96bf9f](a96bf9f))
* support the backend breaking changes of icon path
([#959](#959))
([e7d7ad3](e7d7ad3))

### Bug Fixes

* **dashboard:** chart yAxis calculation
([#929](#929))
([56e9d11](56e9d11))
* fix connector definition not correctly update after user picking up
the existing connector
([#935](#935))
([08ef854](08ef854))
* fix console wrongly warn field not supporting multiple references
([#948](#948))
([3c029e4](3c029e4))
* fix create pipeline dialog use the wrong entity as query param
([#951](#951))
([20d0793](20d0793))
* fix dashboard font-family issue
([#955](#955))
([4028d53](4028d53))
* fix not correctly redirect user to 404 page when the entity is not
found ([#950](#950))
([898acba](898acba))
* fix not redirect non exist user page to 404
([#941](#941))
([86a823f](86a823f))
* fix reference data type tags are not human readable issue
([#960](#960))
([55d315c](55d315c))
* fix stripe subscription detail is not nullable issue
([#966](#966))
([78d903b](78d903b))
* fix the button title for multiple videos uploader at start operator
([#961](#961))
([29a25ab](29a25ab))
* fix the wrong delete organization function parameter
([#952](#952))
([8e2d89f](8e2d89f))
* fix the wrong organization profile object
([#946](#946))
([1f9780b](1f9780b))
* fix useInstillForm field's description tooltip break words issue
([#937](#937))
([6e43839](6e43839))
* **pipeline-builder:** fix newly added nodes is behind old nodes
([#939](#939))
([6824bb1](6824bb1))
* **pipeline-builder:** fix semi-structured/json at start operator not
obey the protocol
([#962](#962))
([bd624a6](bd624a6))
* **pipeline-builder:** fix smart-hint list not align to left when the
key is too long
([#938](#938))
([31ea1c6](31ea1c6))
* **pipeline-builder:** fix task description not react to the selected
task ([#944](#944))
([7e600f8](7e600f8))
* **pipeline-builder:** fix the reference header title have tooltip and
is able to copy
([#958](#958))
([6214838](6214838))
* **pipeline-builder:** prevent user create duplicated field on start
and end operator
([#963](#963))
([a96b0a0](a96b0a0))

### Miscellaneous

* add the missing return button in the subscription form (They are
already in the design handover)
([#932](#932))
([03ef163](03ef163))
* **user-profile:** add id to user profile bio for better URL navigation
([#931](#931))
([3bcd905](3bcd905))
* componentize the UploadAvatarFieldWithCrop
([#953](#953))
([62cbb1b](62cbb1b))

</details>

<details><summary>@instill-ai/design-system: 0.64.0</summary>

##
[0.64.0](https://github.com/instill-ai/console/compare/@instill-ai/design-system-v0.63.0...@instill-ai/design-system-v0.64.0)
(2024-02-15)


### Features

* **pipeline-builder:** support video/multiple-video in pipeline builder
([#943](#943))
([2680f70](2680f70))


### Miscellaneous

* **design-system:** add storybook stories for colors
([#945](#945))
([f4d52d8](f4d52d8))
</details>

<details><summary>@instill-ai/toolkit: 0.81.0</summary>

##
[0.81.0](https://github.com/instill-ai/console/compare/@instill-ai/toolkit-v0.80.3...@instill-ai/toolkit-v0.81.0)
(2024-02-15)


### Features

* adapt new backend breaking changes about mgmt backend
([#940](#940))
([3351262](3351262))
* add SubscriptionStatus to sdk
([#964](#964))
([f5e67ba](f5e67ba))
* add trial_end field into StripeSubscriptionDetail
([#965](#965))
([7b7324b](7b7324b))
* **auto-gen-form:** handle Airbyte form and instill data form
separately ([#956](#956))
([23ce0eb](23ce0eb))
* componentize the UploadAvatarFieldWithCrop
([#953](#953))
([62cbb1b](62cbb1b))
* namananand/ins 3605 add realease switch dropdown, share and delete
button to view pipeline page
([#942](#942))
([a96bf9f](a96bf9f))
* **pipeline-builder:** copy & paste full reference with ${} instead of
path only ([#967](#967))
([231ac2f](231ac2f))
* **pipeline-builder:** implement the layered flow of smart hint
([#934](#934))
([69dc912](69dc912))
* **pipeline-builder:** implement the new array data type label design
([#957](#957))
([0c6ef4e](0c6ef4e))
* **pipeline-builder:** replace semi-structured/object with
semi-structured/json on start operator
([#954](#954))
([df71434](df71434))
* **pipeline-builder:** support hinting other type that can be
stringified ([#949](#949))
([c0c8892](c0c8892))
* **pipeline-builder:** support video/multiple-video in pipeline builder
([#943](#943))
([2680f70](2680f70))
* **pipeline-builder:** unify the onEdit and onDelete item on both start
and end operator
([#936](#936))
([d70120f](d70120f))
* support the backend breaking changes of icon path
([#959](#959))
([e7d7ad3](e7d7ad3))


### Bug Fixes

* **dashboard:** chart yAxis calculation
([#929](#929))
([56e9d11](56e9d11))
* fix connector definition not correctly update after user picking up
the existing connector
([#935](#935))
([08ef854](08ef854))
* fix console wrongly warn field not supporting multiple references
([#948](#948))
([3c029e4](3c029e4))
* fix create pipeline dialog use the wrong entity as query param
([#951](#951))
([20d0793](20d0793))
* fix dashboard font-family issue
([#955](#955))
([4028d53](4028d53))
* fix not correctly redirect user to 404 page when the entity is not
found ([#950](#950))
([898acba](898acba))
* fix not redirect non exist user page to 404
([#941](#941))
([86a823f](86a823f))
* fix reference data type tags are not human readable issue
([#960](#960))
([55d315c](55d315c))
* fix stripe subscription detail is not nullable issue
([#966](#966))
([78d903b](78d903b))
* fix the button title for multiple videos uploader at start operator
([#961](#961))
([29a25ab](29a25ab))
* fix the wrong delete organization function parameter
([#952](#952))
([8e2d89f](8e2d89f))
* fix the wrong organization profile object
([#946](#946))
([1f9780b](1f9780b))
* fix useInstillForm field's description tooltip break words issue
([#937](#937))
([6e43839](6e43839))
* **pipeline-builder:** fix newly added nodes is behind old nodes
([#939](#939))
([6824bb1](6824bb1))
* **pipeline-builder:** fix semi-structured/json at start operator not
obey the protocol
([#962](#962))
([bd624a6](bd624a6))
* **pipeline-builder:** fix smart-hint list not align to left when the
key is too long
([#938](#938))
([31ea1c6](31ea1c6))
* **pipeline-builder:** fix task description not react to the selected
task ([#944](#944))
([7e600f8](7e600f8))
* **pipeline-builder:** fix the reference header title have tooltip and
is able to copy
([#958](#958))
([6214838](6214838))
* **pipeline-builder:** prevent user create duplicated field on start
and end operator
([#963](#963))
([a96b0a0](a96b0a0))


### Miscellaneous

* add the missing return button in the subscription form (They are
already in the design handover)
([#932](#932))
([03ef163](03ef163))
* **instill-hub:** add visibility all label to dropdown
([#947](#947))
([1ba36a0](1ba36a0))
* **user-profile:** add id to user profile bio for better URL navigation
([#931](#931))
([3bcd905](3bcd905))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EiffelFly EiffelFly EiffelFly approved these changes

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@iamnamananand996 @EiffelFly