Skip to content
This repository has been archived by the owner on Aug 24, 2023. It is now read-only.

fix(model,connector,pipeline): update resource name to uuid #25

Merged
merged 1 commit into from
May 5, 2023

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented May 5, 2023

Because

  • account for duplicate resource name from different user

This commit

  • update resource name to uuid

@linear
Copy link

linear bot commented May 5, 2023

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.54 ⚠️

Comparison is base (47b1bbc) 11.97% compared to head (07e3c9f) 10.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   11.97%   10.43%   -1.54%     
==========================================
  Files           4        4              
  Lines         618      690      +72     
==========================================
- Hits           74       72       -2     
- Misses        540      614      +74     
  Partials        4        4              
Flag Coverage Δ
unittests 10.43% <0.00%> (-1.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/service/connector.go 0.00% <0.00%> (ø)
pkg/service/model.go 0.00% <0.00%> (ø)
pkg/service/pipeline.go 0.00% <0.00%> (ø)
pkg/service/service.go 24.48% <0.00%> (-5.35%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@heiruwu heiruwu merged commit 97dd55d into main May 5, 2023
14 checks passed
@heiruwu heiruwu deleted the heiru/ins-603-fix-controller-resource-name branch May 5, 2023 23:12
heiruwu pushed a commit that referenced this pull request May 5, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.1.3-alpha](v0.1.2-alpha...v0.1.3-alpha)
(2023-05-05)


### Bug Fixes

* **model,connector,pipeline:** update resource name to uuid
([#25](#25))
([97dd55d](97dd55d))


### Miscellaneous Chores

* **release:** release v0.1.3-alpha
([47b1bbc](47b1bbc))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
1 participant