Skip to content
This repository has been archived by the owner on Aug 24, 2023. It is now read-only.

chore: add a workaround method for goroutine order problem #41

Conversation

donch1989
Copy link
Member

Because

  • the controller probe mechanism failed sometimes

This commit

  • fix the problem caused by order of goroutines

@linear
Copy link

linear bot commented Jun 20, 2023

INS-951 find out the root clause that sometimes controller can not successfully check connector

Maybe it is caused by the slow startup for connector when first downloading Airbyte image. Need to look into this deeper.

cc heiru

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (83c4b3c) 12.08% compared to head (6a21533) 12.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   12.08%   12.08%           
=======================================
  Files           4        4           
  Lines         596      596           
=======================================
  Hits           72       72           
  Misses        520      520           
  Partials        4        4           
Flag Coverage Δ
unittests 12.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@heiruwu heiruwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donch1989 donch1989 merged commit 18b60d9 into main Jun 20, 2023
14 checks passed
@donch1989 donch1989 deleted the huitang/ins-951-find-out-the-root-clause-that-sometimes-controller-can-not branch June 20, 2023 11:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
2 participants