Skip to content

Commit

Permalink
feat: add console e2e test into vdp (#148)
Browse files Browse the repository at this point in the history
Because

- The console integration test is ready

This commit

- add console e2e test into vdp
- update ITMODE=true when running integration-test. When the flag ITMODE is enabled, the integration-test use dummy models instead of pulling from GitHub, HuggingFace, or ArtiVC to reduce the impact of the internet connection.

Co-authored-by: Phelan164 <phelan.nguyen@instill.tech>
  • Loading branch information
EiffelFly and Phelan164 committed Nov 24, 2022
1 parent f8eb67a commit a779a11
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .env
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,8 @@ TEMPORAL_UI_PORT=8088
REDOC_OPENAPI_VERSION=v2.0.0-rc.70
REDOC_OPENAPI_HOST=redoc-openapi
REDOC_OPENAPI_PORT=3001

# This flag is used for integration test in which dummy model is used instead of pulling model from GitHub, HuggingFace or ArtiVC.
# The reason is reducing the impact of network trouble during integration test
# The default value is alway false, only set when running `make integration-test`
ITMODE=false
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ doc: ## Run Redoc for OpenAPI spec at http://localhost:3001
.PHONY: integration-test
integration-test: ## Run integration test for all dev repositories
@make build PROFILE=all
@make dev PROFILE=all
@make dev PROFILE=all ITMODE=true
@cd dev/console && npm install && npx playwright install && npx playwright test
@cd dev/pipeline-backend && HOSTNAME=localhost make integration-test
@cd dev/connector-backend && HOSTNAME=localhost make integration-test
@cd dev/model-backend && HOSTNAME=localhost make integration-test
Expand Down
3 changes: 2 additions & 1 deletion docker-compose-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ services:
environment:
CFG_SERVER_PORT: 8083
CFG_SERVER_DEBUG: "true"
CFG_SERVER_ITMODE: ${ITMODE}
CFG_SERVER_DISABLEUSAGE: ${DISABLEUSAGE}
CFG_SERVER_EDITION: local-ce:latest
CFG_DATABASE_HOST: ${POSTGRESQL_HOST}
Expand Down Expand Up @@ -388,7 +389,7 @@ services:
environment:
NVIDIA_VISIBLE_DEVICES: 0
LD_PRELOAD: /opt/tritonserver/lib/libgomp-d22c30c5.so.1
command: tritonserver --model-store=/model-repository --model-control-mode=explicit --allow-http=true --strict-model-config=false --log-verbose=1
command: tritonserver --model-store=/model-repository --model-control-mode=explicit --allow-http=true --strict-model-config=false
ports:
- ${TRITON_SERVER_PORT}:8001
volumes:
Expand Down

0 comments on commit a779a11

Please sign in to comment.