Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mgmt): run migration only on main cluster in mgmt-backend #1007

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

jvallesm
Copy link
Collaborator

@jvallesm jvallesm commented Jun 3, 2024

Because

  • Cloud features require migrations to be run on a given cluster.

This commit

  • Creates the isPrimaryCluster variable and uses it to enable the migration process on mgmt-backend.

@jvallesm jvallesm self-assigned this Jun 3, 2024
Copy link

linear bot commented Jun 3, 2024

@jvallesm jvallesm changed the title feat: run migration only on main cluster in mgmt-backend feat(mgmt): run migration only on main cluster in mgmt-backend Jun 3, 2024
@jvallesm jvallesm marked this pull request as ready for review June 3, 2024 06:45
Copy link
Member

@donch1989 donch1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvallesm jvallesm merged commit 26fedff into main Jun 3, 2024
36 of 38 checks passed
@jvallesm jvallesm deleted the jvalles/ins-4437-advanced-credit-subscription branch June 3, 2024 07:23
donch1989 pushed a commit that referenced this pull request Jun 6, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.33.0-beta](v0.32.0-beta...v0.33.0-beta)
(2024-06-06)


### Features

* **artifact:** add minio and milvus for artifact storage
([#999](#999))
([14713d9](14713d9))
* **mgmt:** run migration only on main cluster in mgmt-backend
([#1007](#1007))
([26fedff](26fedff))
* **ray:** update infra to accommodate containerized model serving
([#494](#494))
([8c4b3e1](8c4b3e1))


### Bug Fixes

* **artifact:** modify healthy check request
([#1003](#1003))
([c4225aa](c4225aa))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
donch1989 pushed a commit that referenced this pull request Jun 6, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.33.0-beta](v0.32.0-beta...v0.33.0-beta)
(2024-06-06)


### Features

* **artifact:** add minio and milvus for artifact storage
([#999](#999))
([14713d9](14713d9))
* **mgmt:** run migration only on main cluster in mgmt-backend
([#1007](#1007))
([26fedff](26fedff))
* **ray:** update infra to accommodate containerized model serving
([#494](#494))
([8c4b3e1](8c4b3e1))


### Bug Fixes

* **artifact:** modify healthy check request
([#1003](#1003))
([c4225aa](c4225aa))


### Miscellaneous Chores

* release v0.33.0-beta
([1cc19b9](1cc19b9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👋 Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants