-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(artifact): add minio and milvus for artifact storage #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heiruwu
requested review from
donch1989,
jvallesm and
Sarthak-instill
as code owners
May 20, 2024 17:42
heiruwu
changed the title
feat(artifact): add minio and milvus for artifact storage solution
feat(artifact): add minio and milvus for artifact storage
May 20, 2024
jvallesm
reviewed
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for handling this 🙇
public github runner for helm tests does not have enough cpu resource for the helm deployment, and causing |
donch1989
pushed a commit
that referenced
this pull request
Jun 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.33.0-beta](v0.32.0-beta...v0.33.0-beta) (2024-06-06) ### Features * **artifact:** add minio and milvus for artifact storage ([#999](#999)) ([14713d9](14713d9)) * **mgmt:** run migration only on main cluster in mgmt-backend ([#1007](#1007)) ([26fedff](26fedff)) * **ray:** update infra to accommodate containerized model serving ([#494](#494)) ([8c4b3e1](8c4b3e1)) ### Bug Fixes * **artifact:** modify healthy check request ([#1003](#1003)) ([c4225aa](c4225aa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
donch1989
pushed a commit
that referenced
this pull request
Jun 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.33.0-beta](v0.32.0-beta...v0.33.0-beta) (2024-06-06) ### Features * **artifact:** add minio and milvus for artifact storage ([#999](#999)) ([14713d9](14713d9)) * **mgmt:** run migration only on main cluster in mgmt-backend ([#1007](#1007)) ([26fedff](26fedff)) * **ray:** update infra to accommodate containerized model serving ([#494](#494)) ([8c4b3e1](8c4b3e1)) ### Bug Fixes * **artifact:** modify healthy check request ([#1003](#1003)) ([c4225aa](c4225aa)) ### Miscellaneous Chores * release v0.33.0-beta ([1cc19b9](1cc19b9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
resolves ins-4119