Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(makefile): fix linux integration test host #273

Merged
merged 4 commits into from
May 9, 2023

Conversation

donch1989
Copy link
Member

@donch1989 donch1989 commented May 7, 2023

Because

  • The integration test host for linux system in Makefile is wrong
  • Currently, the posgreSQL set max_connection: 100. But here we set each backend's connection pool size to 1024. 1024 connection * 4 backend is far exceed 100. We should make it smaller.
  • The triton.nvidiaVisibleDevices = all config will stop the triton server running on cpu-only machine
  • The console e2e test won't work on linux machine

This commit

  • Fix integration test host for linux system in Makefile
  • Update connection pool size
  • Pass nvidiaVisibleDevices from env.
  • Fix console e2e test by removing serverApiGatewayBaseUrl from makefile helm install

@donch1989 donch1989 marked this pull request as ready for review May 7, 2023 16:17
@donch1989 donch1989 force-pushed the huitang/fix_makefile branch 3 times, most recently from a5f6b49 to 8c2effd Compare May 8, 2023 08:55
@donch1989 donch1989 marked this pull request as draft May 8, 2023 10:04
Makefile Show resolved Hide resolved
@donch1989 donch1989 marked this pull request as ready for review May 8, 2023 11:51
@xiaofei-du xiaofei-du merged commit 6e3bd4e into main May 9, 2023
8 checks passed
@xiaofei-du xiaofei-du deleted the huitang/fix_makefile branch May 9, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants