fix(ray): check CDI availability for model container #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
=====================================
Coverage 0.99% 0.99%
=====================================
Files 15 15
Lines 5819 5819
=====================================
Hits 58 58
Misses 5753 5753
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
heiruwu
added a commit
that referenced
this pull request
Mar 19, 2024
Because - When deploying CPU model will result in `Error: setting up CDI devices: unresolvable CDI devices nvidia.com/gpu=all` This commit - add `gpu` flag in model configuration for Nvidia CDI setup
heiruwu
pushed a commit
that referenced
this pull request
Jun 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.24.0-alpha](v0.23.0-alpha...v0.24.0-alpha) (2024-06-06) ### ⚠ BREAKING CHANGES * **model:** adopt containerized model serving ([#542](#542)) ### Features * **handler:** implement get latest operation ([#589](#589)) ([33d2395](33d2395)) * **handler:** support listing available regions for model deployment ([#561](#561)) ([52c2172](52c2172)) * **handler:** support model profile image ([#566](#566)) ([0c8dbba](0c8dbba)) * **model:** add permission field in model object ([#576](#576)) ([2d36a58](2d36a58)) * **model:** add task schema in model struct ([#578](#578)) ([647069d](647069d)) * **model:** adopt containerized model serving ([#542](#542)) ([3c80f39](3c80f39)) * **model:** embed sample input/output in model proto message ([#558](#558)) ([5fba538](5fba538)) * **model:** support latest model version trigger ([#580](#580)) ([47cb36c](47cb36c)) * **model:** support resource spec in model definition ([#557](#557)) ([fee6e4b](fee6e4b)) * **model:** support search/filter with list endpoints ([#559](#559)) ([7b17393](7b17393)) * **model:** support watch latest model and `order_by` for list endpoints ([#586](#586)) ([1a5e48c](1a5e48c)) * **prediction:** implement sync/async prediction records ([#555](#555)) ([8d58eda](8d58eda)) * **ray:** support containerized model deployment ([#529](#529)) ([4dcab05](4dcab05)) * **ray:** support custom accelerator type ([#547](#547)) ([f0cc0d7](f0cc0d7)) ### Bug Fixes * **acl:** fix wrong type name ([#560](#560)) ([89d09a5](89d09a5)) * **dockerfile:** update deploy config yaml path ([#590](#590)) ([ee369e0](ee369e0)) * **model:** fix missing package in test models ([#552](#552)) ([a28a21b](a28a21b)) * **ray:** check CDI availability for model container ([#538](#538)) ([28bad42](28bad42)) * **server:** add missing message size option ([#597](#597)) ([d0a0aac](d0a0aac)) * **service:** fix list model version pagination ([#569](#569)) ([d8fb04a](d8fb04a)) * **service:** fix list model version return list size ([#556](#556)) ([9b69f9c](9b69f9c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Error: setting up CDI devices: unresolvable CDI devices nvidia.com/gpu=allThis commit
gpuflag in model configuration for Nvidia CDI setup