Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create single triton client #357

Merged

Conversation

Phelan164
Copy link
Contributor

Because

  • grpc triton client should not create per multipart request

This commit

  • create a single triton client and pass to multipart handler methods

@linear
Copy link

linear bot commented May 5, 2023

INS-588 Integration test failed with helm deployment

Multipart trigger inference failed randomly

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (0c31939) 2.29% compared to head (0f4d000) 2.31%.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #357      +/-   ##
========================================
+ Coverage   2.29%   2.31%   +0.02%     
========================================
  Files         10      10              
  Lines       4447    4361      -86     
========================================
- Hits         102     101       -1     
+ Misses      4322    4237      -85     
  Partials      23      23              
Flag Coverage Δ
unittests 2.31% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/handler/public_handler.go 0.00% <0.00%> (ø)
pkg/service/service.go 10.59% <0.00%> (-0.21%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Phelan164 Phelan164 merged commit 8dedf5d into main May 5, 2023
11 checks passed
@Phelan164 Phelan164 deleted the phelannguyen/ins-588-integration-test-failed-with-helm branch May 5, 2023 07:46
Phelan164 pushed a commit that referenced this pull request May 5, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.16.3-alpha](v0.16.2-alpha...v0.16.3-alpha)
(2023-05-05)


### Bug Fixes

* create single triton client
([#357](#357))
([8dedf5d](8dedf5d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Phelan164 pushed a commit that referenced this pull request May 6, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.16.3-alpha](v0.16.2-alpha...v0.16.3-alpha)
(2023-05-06)


### Bug Fixes

* create single triton client
([#357](#357))
([8dedf5d](8dedf5d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
1 participant