fix(model): move name and version out of updated model info message s…

…truct (#29) * fix: move name and version out of updated model info message struct * chore: update update model method body with entity
instill-ai · Feb 24, 2022 · 919a751 · 919a751
1 parent 9bd38a3
commit 919a751
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/model/model.proto b/model/model.proto
@@ -40,8 +40,8 @@ service Model {
 
   rpc UpdateModel (UpdateModelRequest) returns (ModelInfo) {
     option (google.api.http) = {
-      patch: "/models/{model.name}/versions/{model.version}"
-      body: "*"
+      patch: "/models/{name}/versions/{version}"
+      body: "model"
     };
   }
 
@@ -97,15 +97,15 @@ message DeleteModelVersionRequest {
 }
 
 message UpdateModelRequest {
-  UpdateModelInfo model                 = 1 [(google.api.field_behavior) = REQUIRED];
-  google.protobuf.FieldMask update_mask = 2 [(google.api.field_behavior) = REQUIRED];
+  string name                           = 1 [(google.api.field_behavior) = REQUIRED];
+  int32 version                         = 2 [(google.api.field_behavior) = REQUIRED];
+  UpdateModelInfo model                 = 3 [(google.api.field_behavior) = REQUIRED];
+  google.protobuf.FieldMask update_mask = 4 [(google.api.field_behavior) = REQUIRED];
 }
 
 message UpdateModelInfo {
-  string name                    = 1 [(google.api.field_behavior) = REQUIRED];
-  int32 version                  = 2 [(google.api.field_behavior) = REQUIRED];
-  ModelStatus status             = 3;
-  string description             = 4;
+  ModelStatus status             = 1;
+  string description             = 2;
 }
 
 message GetModelRequest {