Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): remove base #13

Merged
merged 2 commits into from
Oct 25, 2023
Merged

chore(core): remove base #13

merged 2 commits into from
Oct 25, 2023

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented Oct 25, 2023

Because

  • adopt renaming of base to core

This commit

  • remove old base files

pinglin
pinglin previously approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@pinglin pinglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinglin pinglin merged commit c949edc into main Oct 25, 2023
@pinglin pinglin deleted the remove-base branch October 25, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinglin pinglin pinglin left review comments

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@heiruwu @pinglin