Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable value trimming for default_value interpreter #407

Open
wants to merge 1 commit into
base: 4.0
Choose a base branch
from

Conversation

dolmit-tanel-paaro
Copy link
Contributor

@dolmit-tanel-paaro dolmit-tanel-paaro commented Nov 29, 2023

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets -

In our project, we wanted to import single space strings using default_value interpreter. To our surprise, we couldn't, as Symfony trims the value by default.

In my opinion, the interpreter should not modify the value, ever. It's up to user to validate it.

@dolmit-tanel-paaro dolmit-tanel-paaro changed the title disable value trimming for default_value interpreter Disable value trimming for default_value interpreter Nov 29, 2023
@dpfaffenbauer
Copy link
Collaborator

@dolmit-tanel-paaro this is a BC break and should be configurable

@dolmit-tanel-paaro
Copy link
Contributor Author

@dpfaffenbauer
I don't see the reason to make it configurable. This is because the value should never be altered - it should be whatever the user has defined.
I suggest to mention this change in the upgrade notes so people can check their default value interpreters configuration.

@dpfaffenbauer
Copy link
Collaborator

@dolmit-tanel-paaro Problem is that its been altered since we have that interpreter, if we change it, we might mess up existing definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants