Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accidental Unapproved/Leaked knowledge submissions #325

Open
jjasghar opened this issue Jun 24, 2024 · 3 comments
Open

Accidental Unapproved/Leaked knowledge submissions #325

jjasghar opened this issue Jun 24, 2024 · 3 comments
Assignees
Labels

Comments

@jjasghar
Copy link
Member

jjasghar commented Jun 24, 2024

We should create a standard process for possible leaked or unapproved knowledge submissions.

Something along the lines of:

  1. Contact and ask the submitter with a standard, "Are you sure you wanted to submit this?"
  2. With in reasonable amount of time, if there no response, as a maintainer edit the PR and remove the content
  3. Close the PR to "lock it down."
  4. Remove the PR via contact with GitHub if needed
  5. Contact the response team (if needed) of the entity that owns the IP
@jjasghar
Copy link
Member Author

jjasghar commented Jun 24, 2024

To wipe out the files in the PR, we need to force push to the submitter's fork while the PR is still open. A maintainer should have this permission.

First, in your local clone, checkout the PR using the gh command. Using the gh command sets the proper config for pushing back to the submitter's fork.

gh pr checkout pr_number

where pr_number is replaced by the PR number.

The you need to remove all the troublesome commits.

git reset --hard HEAD^

removes one commit. Repeat as necessary to remove all desired commits.

Then we need to push back to the submitter's fork. If the submitter used a branch (other than main):

git push --force

If however the submitter made the PR from their main branch:

git push git@github.com:github_user/taxonomy.git HEAD:main --force

where github_user/taxonomy is replaced by the submitter's fork.

After this, the PR can be otherwise changed (edit comments, close).

@bjhargrave
Copy link
Contributor

See instructlab/dev-docs#24 which covers this same topic.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had activity within 90 days. It will be automatically closed if no further activity occurs within 30 days.

@github-actions github-actions bot added the stale label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants