Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch To InstructLab Dolomite Repo #55

Merged
merged 5 commits into from
Jun 23, 2024

Conversation

fabianlim
Copy link
Contributor

@fabianlim fabianlim commented Jun 20, 2024

This PR addresses #49

This should be merged only until instructlab/GPTDolomite#1 is merged.

Our tests show the extracted repo matches the original.

Updated picture

tested again after instructlab/GPTDolomite#3

  • see those that are tagged with mayank.
  • tested with both regular and universal checkpoint resumption.

image

Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
@fabianlim fabianlim changed the title Switch To InstructLab Dolomite Repo: DO NOT MERGE Switch To InstructLab Dolomite Repo Jun 21, 2024
Copy link
Contributor

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM whenever you are ready to merge and everything works

Copy link
Contributor

@JamesKunstle JamesKunstle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since lift-and-shift

Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
@fabianlim
Copy link
Contributor Author

@RobotSail @Maxusmusti we have published the dolomite PYPI, and i have switched to requirements file to that. Care to do the honours of merging? I believe then we can release the training package.

@RobotSail RobotSail merged commit 01cbcd7 into instructlab:main Jun 23, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants