This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Add support for the time crate
#32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Mythra
suggested changes
Nov 13, 2020
This commit puts `chrono` behind a feature flag and adds `time` as an alternative to it.
Mythra
reviewed
Nov 18, 2020
|
Ok...this should again be ready for a review. Hopefully the final one 😅🙃. Sorry for missing all the little things. |
Mythra
approved these changes
Nov 19, 2020
|
You are welcome. And happy to hear that. |
|
Good work on this PR! I am a happy user of the lib and hope a new version can be released. Would that be an option? |
|
Hey @frederikbosch , Yep I'm getting to it, unfortunately have had some other things pop up first. But I'll schedule for some time for it, at the latest I'd expect this weekend. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit puts
chronobehind a feature flag and addstimeas an alternative to it.One thing to note is, that i had to exclude https://github.com/Weasy666/paseto/blob/1b97dcb99565807e43057e96470a03472ed9ac46/src/tokens/mod.rs#L51 from being build, when both features
easy_token_chronoandeasy_token_timeare activated, as there is no way to guess which time crate should be used to parse the json time.