Merge pull request #283 from instrumenta/issue-246

fix: do not fail on empty lists
instrumenta · Mar 30, 2021 · c63749c · c63749c
2 parents 258f4a4 + 026c0d6
commit c63749c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/fixtures/list_empty_valid.yaml b/fixtures/list_empty_valid.yaml
@@ -0,0 +1,4 @@
+---
+apiVersion: v1
+kind: List
+items: []
diff --git a/kubeval/kubeval.go b/kubeval/kubeval.go
@@ -284,7 +284,7 @@ func ValidateWithCache(input []byte, schemaCache map[string]*gojsonschema.Schema
 	}{}
 
 	unmarshalErr := yaml.Unmarshal(input, &list)
-	isYamlList := unmarshalErr == nil && list.Items != nil && len(list.Items) > 0
+	isYamlList := unmarshalErr == nil && list.Items != nil
 
 	var bits [][]byte
 	if isYamlList {

diff --git a/kubeval/kubeval_test.go b/kubeval/kubeval_test.go
@@ -36,6 +36,7 @@ func TestValidateValidInputs(t *testing.T) {
 		"full_domain_group.yaml",
 		"unconventional_keys.yaml",
 		"list_valid.yaml",
+		"list_empty_valid.yaml",
 		"same-object-different-namespace.yaml",
 		"same-object-different-namespace-default.yaml",
 		"duplicates-skipped-kinds.yaml",