Skip to content
This repository has been archived by the owner on May 6, 2021. It is now read-only.

Dockerfile states configuration file is not taken into account by default #18

Closed
KoltesDigital opened this issue Mar 18, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@KoltesDigital
Copy link

KoltesDigital commented Mar 18, 2020

This project's README states that one can use their own config file without changing the command:

  1. You may either specify your own configuration file instead.

    docker run -d --network=host
    -v $(pwd)/my.conf:/etc/coturn/turnserver.conf
    instrumentisto/coturn

However, the CMD puts the -n flag, which disables reading from any config file.

CMD ["-n", "--log-file=stdout", "--external-ip=$(detect-external-ip)"]

I suspect the flag is here because coturn fails to start if it can't find a config file. If it's the case, I suggest removing the above section from the README. If not, I suggest removing the -n flag.

FTR, I found this issue because I observed my config file was not taken into account. By adding -c /path/to/turnserver.conf it is.

@KoltesDigital KoltesDigital changed the title Dockerfile states configuration files is not taken into account by default Dockerfile states configuration file is not taken into account by default Mar 18, 2020
@tyranron tyranron self-assigned this Mar 18, 2020
@tyranron tyranron added the bug Something isn't working label Mar 18, 2020
@KoltesDigital
Copy link
Author

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants