Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remote video rotation not being handled properly #124

Merged
merged 17 commits into from
Oct 9, 2023
Merged

Fix remote video rotation not being handled properly #124

merged 17 commits into from
Oct 9, 2023

Conversation

rogurotus
Copy link

@rogurotus rogurotus commented Sep 27, 2023 •
edited by tyranron
Loading

Synopsis

Video from mobile is distorted

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@rogurotus rogurotus added enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::design Applies to changes of application architecture and implementation design platform::windows Specific to Windows platform platform::macos Specific to macOS platform platform::linux Specific to Linux platform labels Sep 27, 2023
@rogurotus rogurotus self-assigned this Sep 27, 2023
@rogurotus
Copy link
Author

rogurotus commented Sep 27, 2023 •
edited by tyranron
Loading

FCM:

Fix remote video rotation not being handled properly (#124)

@rogurotus rogurotus marked this pull request as ready for review September 28, 2023 06:49
@alexlapa alexlapa added the platform::web Specific to WEB platform label Oct 9, 2023
@alexlapa alexlapa changed the title Fix distorted mobile video Fix remote video rotation not being handled properly Oct 9, 2023
@alexlapa alexlapa requested a review from tyranron October 9, 2023 09:15
@tyranron tyranron enabled auto-merge (squash) October 9, 2023 15:31
@tyranron tyranron merged commit 395c876 into main Oct 9, 2023
18 of 19 checks passed
@tyranron tyranron deleted the fix-android-frame-width branch October 9, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

@alexlapa alexlapa alexlapa approved these changes

Assignees

@rogurotus rogurotus

Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::design Applies to changes of application architecture and implementation design platform::linux Specific to Linux platform platform::macos Specific to macOS platform platform::web Specific to WEB platform platform::windows Specific to Windows platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rogurotus @tyranron @alexlapa