Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl track width height getters #129

Merged
merged 19 commits into from
Dec 4, 2023
Merged

Impl track width height getters #129

merged 19 commits into from
Dec 4, 2023

Conversation

rogurotus
Copy link

@rogurotus rogurotus commented Oct 11, 2023 •
edited by tyranron
Loading

Synopsis

Implementation of height and width getters for mediaStreamTracks.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@rogurotus rogurotus added enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::design Applies to changes of application architecture and implementation design platform::windows Specific to Windows platform plarform::android Specific to Android platform platform::macos Specific to macOS platform platform::linux Specific to Linux platform platform::web Specific to WEB platform labels Oct 11, 2023
@rogurotus rogurotus self-assigned this Oct 11, 2023
@rogurotus
Copy link
Author

rogurotus commented Oct 11, 2023 •
edited by tyranron
Loading

FCM:

Implement `MediaStreamTrack.height()` and `MediaStreamTrack.width()` methods (#129)

@rogurotus rogurotus marked this pull request as ready for review October 11, 2023 11:40
@alexlapa
Merge branch 'main' into impl-track-width-height-getters
b314a31 
# Conflicts:
#	crates/native/src/api.rs
#	crates/native/src/bridge_generated.rs
#	lib/src/api/bridge.g.dart
@alexlapa
corections
e5adcc1
@alexlapa
Merge branch 'main' into impl-track-width-height-getters
31b6630
@alexlapa
corections
82ad0a5
@tyranron tyranron added feature New feature or request and removed enhancement Improvement of existing features or bugfix k::design Applies to changes of application architecture and implementation design labels Dec 4, 2023
@tyranron tyranron enabled auto-merge (squash) December 4, 2023 12:18
@tyranron tyranron merged commit 0fe64b4 into main Dec 4, 2023
18 of 19 checks passed
@tyranron tyranron deleted the impl-track-width-height-getters branch December 4, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

@alexlapa alexlapa alexlapa approved these changes

Assignees

@rogurotus rogurotus

Labels
feature New feature or request k::api Related to API (application interface) plarform::android Specific to Android platform platform::linux Specific to Linux platform platform::macos Specific to macOS platform platform::web Specific to WEB platform platform::windows Specific to Windows platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rogurotus @tyranron @alexlapa