Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak when using screensharing on macos #133

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Fix memory leak when using screensharing on macos #133

merged 4 commits into from
Oct 26, 2023

Conversation

alexlapa
Copy link

@alexlapa alexlapa commented Oct 26, 2023 •
edited by tyranron
Loading

Synopsis

macOs starts leaking memory after screensharing video source is created.

Solution

MouseCursorMonitorMac::Capture() leaks memory, wrapping this call in autoreleasepool block fixes this.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@alexlapa alexlapa marked this pull request as ready for review October 26, 2023 11:28
@alexlapa alexlapa self-assigned this Oct 26, 2023
@alexlapa alexlapa added enhancement Improvement of existing features or bugfix k::dependencies Pull requests that update a dependency file labels Oct 26, 2023
@alexlapa
Copy link
Author

alexlapa commented Oct 26, 2023 •
edited by tyranron
Loading

FCM:

Fix memory leak when using screensharing on macOS (#133)

@tyranron tyranron added k::ui/ux Related to UI/UX platform::macos Specific to macOS platform k::performance Related to performance and removed k::dependencies Pull requests that update a dependency file labels Oct 26, 2023
@tyranron tyranron enabled auto-merge (squash) October 26, 2023 14:11
@tyranron tyranron merged commit 1f3fc1e into main Oct 26, 2023
22 checks passed
@tyranron tyranron deleted the fix-macos-mem-leak branch October 26, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@alexlapa alexlapa

Labels
enhancement Improvement of existing features or bugfix k::performance Related to performance k::ui/ux Related to UI/UX platform::macos Specific to macOS platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexlapa @tyranron