Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setParameters() API #135

Merged
merged 30 commits into from
Nov 14, 2023
Merged

Add setParameters() API #135

merged 30 commits into from
Nov 14, 2023

Conversation

logist322
Copy link

@logist322 logist322 commented Oct 31, 2023 •
edited by tyranron
Loading

Synopsis

This PR provides API for getting, modifying and setting sender parameters.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@logist322 logist322 added k::api Related to API (application interface) enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base feature New feature or request labels Oct 31, 2023
@logist322 logist322 self-assigned this Oct 31, 2023
@logist322 logist322 marked this pull request as ready for review November 1, 2023 11:03
@logist322
Copy link
Author

logist322 commented Nov 1, 2023 •
edited by alexlapa
Loading

FCM

Add `RtpSender.setParameters()` API (#135)

@tyranron tyranron added k::toolchain Applies to changes of project toolchain k::dependencies Pull requests that update a dependency file labels Nov 14, 2023
@tyranron tyranron enabled auto-merge (squash) November 14, 2023 16:21
@tyranron tyranron added platform::windows Specific to Windows platform plarform::android Specific to Android platform platform::ios Specific to iOS platform platform::macos Specific to macOS platform platform::linux Specific to Linux platform labels Nov 14, 2023
@tyranron tyranron merged commit 89db8e4 into main Nov 14, 2023
20 of 21 checks passed
@tyranron tyranron deleted the set-params branch November 14, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexlapa alexlapa alexlapa approved these changes

@tyranron tyranron Awaiting requested review from tyranron

Assignees

@logist322 logist322

Labels
enhancement Improvement of existing features or bugfix feature New feature or request k::api Related to API (application interface) k::dependencies Pull requests that update a dependency file k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::toolchain Applies to changes of project toolchain plarform::android Specific to Android platform platform::ios Specific to iOS platform platform::linux Specific to Linux platform platform::macos Specific to macOS platform platform::windows Specific to Windows platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@logist322 @alexlapa @tyranron