Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MacOS video renderer disposing #139

Merged
merged 7 commits into from
Dec 13, 2023
Merged

Fix MacOS video renderer disposing #139

merged 7 commits into from
Dec 13, 2023

Conversation

evdokimovs
Copy link

@evdokimovs evdokimovs commented Dec 8, 2023

Synopsis

At this moment we have bug which is easily reproducible in our getUserMedia example.

Steps for reproduce:

  1. Start GetUserMedia demo
  2. Change video camera to any camera (it can be the same camera)
  3. Change video camera second time
    => segfault

Solution

Fix memory management issues in MacOS's implementation of VideoRenderer.m.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::api Related to API (application interface) platform::macos Specific to macOS platform labels Dec 8, 2023
@evdokimovs evdokimovs self-assigned this Dec 8, 2023
@evdokimovs
Copy link
Author

evdokimovs commented Dec 8, 2023

FCM

Fix double free when macOS video renderer is reused (#139)

Additionally:
- fix TextureVideoRenderer not being unregistered from FlutterTextureRegistry

@evdokimovs evdokimovs marked this pull request as ready for review December 8, 2023 14:16
@tyranron tyranron removed the k::api Related to API (application interface) label Dec 13, 2023
@tyranron tyranron merged commit 7e6a977 into main Dec 13, 2023
22 checks passed
@tyranron tyranron deleted the fix-renderer-gc branch December 13, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base platform::macos Specific to macOS platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants