Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement onDeviceChange method #26

Merged
merged 147 commits into from
Mar 1, 2022
Merged

Conversation

logist322
Copy link

@logist322 logist322 commented Jan 13, 2022

Synopsis

Этот PR реализует метод onDeviceChange.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@alexlapa alexlapa removed their request for review February 8, 2022 13:47
@logist322 logist322 requested review from alexlapa and removed request for alexlapa February 8, 2022 14:36
# Conflicts:
#	crates/native/include/api.h
#	crates/native/src/internal.rs
#	windows/include/flutter_webrtc.h
#	windows/src/flutter_webrtc.cc
# Conflicts:
#	.github/workflows/ci.yml
#	example/pubspec.yaml
#	windows/src/flutter_webrtc.cc
# Conflicts:
#	crates/native/include/api.h
#	crates/native/src/internal.rs
#	crates/native/src/lib.rs
#	windows/include/media_stream.h
#	windows/src/media_stream.cc
Copy link

@alexlapa alexlapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@logist322 ,

Discussed, added todos

@alexlapa alexlapa marked this pull request as ready for review February 28, 2022 14:22
@logist322 logist322 requested a review from alexlapa March 1, 2022 07:24
@alexlapa alexlapa requested a review from tyranron March 1, 2022 12:07
@tyranron tyranron enabled auto-merge (squash) March 1, 2022 16:41
@tyranron tyranron merged commit e78c734 into windows-rework Mar 1, 2022
@tyranron tyranron deleted the implement-on-device-change branch March 1, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::design Applies to changes of application architecture and implementation design platform::windows Specific to Windows platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants