Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WebAudioRenderer not removing its audio element #46

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Fix WebAudioRenderer not removing its audio element #46

merged 2 commits into from
Mar 25, 2022

Conversation

SleepySquash
Copy link

@SleepySquash SleepySquash commented Mar 24, 2022 •
edited by tyranron
Loading

Synopsis

This PR fixes WebAudioRenderer not removing its audio element in dispose function.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@SleepySquash SleepySquash added enhancement Improvement of existing features or bugfix k::design Applies to changes of application architecture and implementation design platform::web Specific to WEB platform labels Mar 24, 2022
@SleepySquash SleepySquash self-assigned this Mar 24, 2022
@SleepySquash
Copy link
Author

FCM

Fix `WebAudioRenderer` not removing its audio element (#46)

@SleepySquash SleepySquash marked this pull request as ready for review March 24, 2022 14:19
@alexlapa
Copy link

@evdokimovs , ack

@alexlapa alexlapa requested a review from tyranron March 24, 2022 18:19
@tyranron tyranron changed the title Draft: Fix WebAudioRenderer not removing its audio element Fix WebAudioRenderer not removing its audio element Mar 25, 2022
@tyranron tyranron merged commit 7f3a633 into master Mar 25, 2022
@tyranron tyranron deleted the fix-audio-renderers-dispose branch March 25, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

@alexlapa alexlapa alexlapa approved these changes

Assignees

@SleepySquash SleepySquash

Labels
enhancement Improvement of existing features or bugfix k::design Applies to changes of application architecture and implementation design platform::web Specific to WEB platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SleepySquash @alexlapa @tyranron