Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Android implementation #6

Merged
merged 6 commits into from
Jan 10, 2022
Merged

Refactor Android implementation #6

merged 6 commits into from
Jan 10, 2022

Conversation

evdokimovs
Copy link

@evdokimovs evdokimovs commented Nov 8, 2021

Synopsis

Этот PR фиксит ряд багов flutter_webrtc на Android'е.

Фиксится обновление mid'ов Transceiver'а, работа FlutterRTCVideoRenderer, выдача идентификаторов для Transceiver'ов. Была убрана часть кода оставшегося от plan-b. Также, теперь Java сторона flutter_webrtc не хранит libwebrtc хэндлы, которые могут быть неконтроллируемо очищены, и соответственно пофикшены баги приводящие к выбросу ошибок о том, что libwebrtc хэндл был очищен.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::api Related to API (application interface) labels Nov 8, 2021
@evdokimovs evdokimovs self-assigned this Nov 8, 2021
@evdokimovs
Copy link
Author

evdokimovs commented Nov 8, 2021

FCM

Refactor Android implementation (#6)

- fix `Transceiver` `mid` update
- use `Transceiver` IDs instead of `mid`
- fix disposed `libwebrtc` handles usage on Java side
- clean some remaining parts of plan-b on Android

@evdokimovs evdokimovs marked this pull request as ready for review November 8, 2021 09:46
@tyranron tyranron added the plarform::android Specific to Android platform label Dec 25, 2021
@alexlapa
Copy link

@tyranron,

Мы еще хотим автоформат жавовских сорцов отдельным PR'ом сделать, а то тут сейчас все странно в этом плане. Код менять не будем, только форматирование.

@tyranron tyranron changed the title Draft: Refactor Android implementation Refactor Android implementation Jan 10, 2022
@evdokimovs evdokimovs merged commit eda3388 into master Jan 10, 2022
@evdokimovs evdokimovs deleted the android-refactoring branch January 10, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::refactor Refactoring, technical debt elimination and other improvements of existing code base plarform::android Specific to Android platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants