Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocalMediaTrack onEnded #109

Merged
merged 16 commits into from
Apr 3, 2023
Merged

LocalMediaTrack onEnded #109

merged 16 commits into from
Apr 3, 2023

Conversation

rogurotus
Copy link
Contributor

@rogurotus rogurotus commented Mar 2, 2023 •
edited by tyranron
Loading

Synopsis

This PR expose onEnded callback and readyState getter on a LocalMediaTrack. #101

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@rogurotus rogurotus requested a review from alexlapa March 2, 2023 07:52
@rogurotus rogurotus self-assigned this Mar 2, 2023
@rogurotus rogurotus added enhancement Improvement of existing features or bugfix k::api Related to API (application interface) platform::android Specific to Android platform platform::ios Specific to iOS platform platform::web Specific to WEB platform platform::windows Specific to Windows platform platform::linux Specific to Linux platform platform::macos Specific to macOS platform labels Mar 2, 2023
@rogurotus
Copy link
Contributor Author

rogurotus commented Mar 2, 2023 •
edited by alexlapa
Loading

FCM

Add `LocalMediaTrack::onEnded` callback (#109, #101)

alexlapa and others added 5 commits March 27, 2023 16:55
@alexlapa
Merge branch 'master' into local-track-onended
3299920 
# Conflicts:
#	flutter/lib/src/web/jason_wasm.dart
#	flutter/lib/src/web/media_device_details.dart
@alexlapa
corrections
5b3d05c
@alexlapa
corrections [skip ci]
dba07a6
@rogurotus
fix
ca5d933
@rogurotus
fix doc
1d9ffc6
@rogurotus rogurotus marked this pull request as ready for review March 28, 2023 18:24
@alexlapa alexlapa requested a review from tyranron March 30, 2023 11:03
@tyranron tyranron enabled auto-merge (squash) April 3, 2023 17:18
@tyranron tyranron merged commit c59ab2a into master Apr 3, 2023
@tyranron tyranron deleted the local-track-onended branch April 3, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

@alexlapa alexlapa alexlapa approved these changes

Assignees

@rogurotus rogurotus

Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface) platform::android Specific to Android platform platform::ios Specific to iOS platform platform::linux Specific to Linux platform platform::macos Specific to macOS platform platform::web Specific to WEB platform platform::windows Specific to Windows platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rogurotus @tyranron @alexlapa