Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect error handling in medea-e2e (#111) #112

Merged
merged 6 commits into from
Mar 24, 2023
Merged

Fix incorrect error handling in medea-e2e (#111) #112

merged 6 commits into from
Mar 24, 2023

Conversation

50U10FCA7
Copy link
Contributor

@50U10FCA7 50U10FCA7 commented Mar 17, 2023 •
edited by tyranron
Loading

Resolves #111

Synopsis

Error in WebDriver logs caused because of incorrect error handling in medea-e2e.

Solution

Check whether error, returned from medea-jason wasm, contains methods to fill the error details.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@50U10FCA7 50U10FCA7 added enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::testing Related to testing and/or automated tests platform::web Specific to WEB platform labels Mar 17, 2023
@50U10FCA7 50U10FCA7 self-assigned this Mar 17, 2023
@50U10FCA7 50U10FCA7 marked this pull request as draft March 17, 2023 19:06
@50U10FCA7
Copy link
Contributor Author

50U10FCA7 commented Mar 20, 2023 •
edited by tyranron
Loading

FCM

Fix incorrect JS error handling in `medea-e2e` (#112, #111)

@50U10FCA7 50U10FCA7 changed the title Fix wrong error handling in medea-e2e (#111) Fix incorrect error handling in medea-e2e (#111) Mar 20, 2023
@50U10FCA7 50U10FCA7 requested a review from alexlapa March 20, 2023 16:31
@alexlapa alexlapa requested a review from tyranron March 23, 2023 13:42
@tyranron tyranron marked this pull request as ready for review March 24, 2023 16:29
@tyranron tyranron removed the k::api Related to API (application interface) label Mar 24, 2023
@tyranron tyranron enabled auto-merge (squash) March 24, 2023 16:30
@tyranron tyranron merged commit adb6ef5 into master Mar 24, 2023
@tyranron tyranron deleted the 111-fix-wrong-error-handling branch March 24, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

@alexlapa alexlapa alexlapa approved these changes

Assignees

@50U10FCA7 50U10FCA7

Labels
enhancement Improvement of existing features or bugfix k::testing Related to testing and/or automated tests platform::web Specific to WEB platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong error handling in medea-e2e
3 participants
@50U10FCA7 @tyranron @alexlapa