Integration with flutter_webrtc #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/platform/dart/utils/mod.rs
…tform-utils # Conflicts: # src/platform/dart/utils/dart_future.rs
|
Изменения по удалению |
alexlapa
approved these changes
Dec 21, 2021
tyranron
requested changes
Dec 22, 2021
tyranron
reviewed
Dec 22, 2021
alexlapa
reviewed
Dec 22, 2021
|
|
||
| /// Wrapper around [WebSocket] which stores WS messages if no one | ||
| /// currently listens to them and provides it to the first subscriber. | ||
| class BufferedWebSocket { |
There was a problem hiding this comment.
В смысле между созданием сокета и моментмо как раст на него подпишется успевают дойти сообщения?
Может сразу в connect прокидывать onMessage и onClose каллбеки?
There was a problem hiding this comment.
И правда перемудрил. В нашем случае это и правда более удачный вариант. Запушил эти изменения.
alexlapa
approved these changes
Dec 23, 2021
tyranron
changed the title
tyranron
approved these changes
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
Это PR из цикла задач по интеграции Jason'а в Flutter Android. В рамках этой задачи, были добавлены оставшиеся биндинги для
flutter_webrtc. В некоторых местах используются заглушки, это связано с тем, что не весь нужный функционал реализован вflutter_webrtcна данный момент. Эти заглушки будут заменены на реальные вызовыflutter_webrtcфункций после его переработки. На этой ветке базово работают звонки на Android'е.Checklist
Draft:prefixk::labels appliedDraft:prefix is removedflutter-webrtcdependency switched back tomasterbranch