Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kind to the MediaStateTransitionException #31

Merged
merged 7 commits into from
Mar 18, 2022
Merged

Add kind to the MediaStateTransitionException #31

merged 7 commits into from
Mar 18, 2022

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Mar 16, 2022 •
edited by tyranron

Synopsis

This PR adds kind() method to the MediaStateTransitionException which will return concrete type of the error.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed
    • flutter-webrtc dependency switched back to master branch

@evdokimovs evdokimovs added feature New feature or request k::api Related to API (application interface) labels Mar 16, 2022
@evdokimovs evdokimovs self-assigned this Mar 16, 2022
@evdokimovs
Copy link
Contributor Author

FCM

Add kind to the `MediaStateTransitionException` (#31)

@evdokimovs evdokimovs changed the title Draft: Add kind to the MediaStateTransitionException Draft: Add kind to the MediaStateTransitionException Mar 16, 2022
@evdokimovs evdokimovs marked this pull request as ready for review March 16, 2022 13:37
alexlapa and others added 3 commits March 18, 2022 11:19
@alexlapa
Merge branch 'master' into add-kind-for-transition-error
a51a14f 
# Conflicts:
#	flutter/android/src/main/jniLibs/arm64-v8a/libmedea_jason.so
#	flutter/android/src/main/jniLibs/armeabi-v7a/libmedea_jason.so
#	flutter/android/src/main/jniLibs/x86/libmedea_jason.so
#	flutter/android/src/main/jniLibs/x86_64/libmedea_jason.so
@alexlapa
corrections [skip ci]
ff459e6
@evdokimovs
Rebuild SO
37ef329
@alexlapa alexlapa requested a review from tyranron March 18, 2022 10:14
@tyranron tyranron added enhancement Improvement of existing features or bugfix and removed feature New feature or request labels Mar 18, 2022
@tyranron tyranron changed the title Draft: Add kind to the MediaStateTransitionException Add kind to the MediaStateTransitionException Mar 18, 2022
@evdokimovs evdokimovs merged commit 7e40186 into master Mar 18, 2022
@evdokimovs evdokimovs deleted the add-kind-for-transition-error branch March 18, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

@alexlapa alexlapa alexlapa approved these changes

Assignees

@evdokimovs evdokimovs

Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evdokimovs @tyranron @alexlapa