Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement methods for the microphone configuration #49

Merged
merged 18 commits into from
Apr 29, 2022
Merged

Implement methods for the microphone configuration #49

merged 18 commits into from
Apr 29, 2022

Conversation

logist322
Copy link
Contributor

@logist322 logist322 commented Apr 22, 2022 •
edited by tyranron

Synopsis

This PR adds the ability of configurating the microphone .

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@logist322 logist322 added feature New feature or request k::api Related to API (application interface) k::documentation Related to project documentation platform::windows Specific to Windows platform platform::linux Specific to Linux platform platform::macos Specific to macOS platform labels Apr 22, 2022
@logist322 logist322 self-assigned this Apr 22, 2022
@logist322
Copy link
Contributor Author

logist322 commented Apr 25, 2022 •
edited by tyranron

FCM

Implement microphone volume controls for desktop platforms (#49)

@logist322 logist322 requested a review from alexlapa April 25, 2022 12:37
@logist322 logist322 marked this pull request as ready for review April 25, 2022 12:40
@alexlapa
corrections
b5e6138
@alexlapa
Merge branch 'master' into impl-micro
e75df91 
# Conflicts:
#	flutter/windows/lib/x86_64-pc-windows-msvc/medea_jason.dll
alexlapa
alexlapa requested changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@alexlapa alexlapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@logist322 , discussed, added todos

@logist322 logist322 requested a review from alexlapa April 28, 2022 12:36
@alexlapa alexlapa requested a review from tyranron April 29, 2022 08:22
@tyranron tyranron added k::design Related to overall design and/or architecture and removed k::documentation Related to project documentation labels Apr 29, 2022
tyranron
tyranron approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@logist322 do not forget about CHANGELOG entries. You have checklist for that.

@tyranron tyranron merged commit 9537565 into master Apr 29, 2022
@tyranron tyranron deleted the impl-micro branch April 29, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

@alexlapa alexlapa alexlapa approved these changes

Assignees

@logist322 logist322

Labels
feature New feature or request k::api Related to API (application interface) k::design Related to overall design and/or architecture platform::linux Specific to Linux platform platform::macos Specific to macOS platform platform::windows Specific to Windows platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@logist322 @tyranron @alexlapa