Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Flutter Web #5

Merged
merged 32 commits into from
Oct 14, 2021
Merged

Support Flutter Web #5

merged 32 commits into from
Oct 14, 2021

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Sep 29, 2021 •
edited by tyranron

Synopsis

It was decided to firstly add Flutter Web support for Jason. So, this PR adds this support.

Solution

  1. Make Flutter Jason API platform agnostic
  2. Implement bindings for the WASM Jason
  3. Add Flutter Web implementation for the Flutter Jason platform agnostic API

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added feature New feature or request k::api Related to API (application interface) k::design Related to overall design and/or architecture labels Sep 29, 2021
@evdokimovs evdokimovs self-assigned this Sep 29, 2021
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Sep 30, 2021 •
edited by tyranron

FCM

Support Flutter Web (#5)

- make Flutter Jason API platform agnostic
- implement Flutter bindings for WASM Jason
- add web implementation for Flutter Jason platform agnostic API

@evdokimovs evdokimovs marked this pull request as ready for review September 30, 2021 11:30
@evdokimovs evdokimovs added the platform::web Specific to WEB platform label Sep 30, 2021
@alexlapa
Copy link
Contributor

alexlapa commented Oct 4, 2021

После мержа просьба ветку не удалять - я сам.

@SleepySquash
Copy link
Contributor

@evdokimovs @alexlapa если можно, не могли бы вы добавить, пожалуйста, export 'src/interface/device_video_track_constraints.dart' в lib/medea_jason.dart? enum FacingMode лежит там, а без этого экспорта его не видно.

alexlapa
alexlapa approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@alexlapa alexlapa left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

flutter/assets/pkg/medea_jason.js 
flutter/assets/pkg/medea_jason_bg.wasm

Это временно, к первому-второму релизу фронта поднимем публикацию на pub.dev.

@tyranron tyranron added k::refactor Refactoring, technical debt elimination and other improvements of existing code base enhancement Improvement of existing features or bugfix labels Oct 14, 2021
@tyranron tyranron changed the title Draft: Add Flutter Web support Add Flutter Web support Oct 14, 2021
@evdokimovs evdokimovs changed the title Add Flutter Web support Support Flutter Web Oct 14, 2021
@evdokimovs evdokimovs merged commit 4e7d81f into master Oct 14, 2021
@evdokimovs evdokimovs deleted the flutter-web-support branch October 14, 2021 12:26
@evdokimovs evdokimovs restored the flutter-web-support branch October 14, 2021 12:26
@alexlapa alexlapa deleted the flutter-web-support branch August 25, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

@alexlapa alexlapa alexlapa approved these changes

Assignees

@evdokimovs evdokimovs

Labels
enhancement Improvement of existing features or bugfix feature New feature or request k::api Related to API (application interface) k::design Related to overall design and/or architecture k::refactor Refactoring, technical debt elimination and other improvements of existing code base platform::web Specific to WEB platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@evdokimovs @alexlapa @SleepySquash @tyranron