Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Upgrade stable Rust to 1.52 version #199

Merged
merged 7 commits into from
May 12, 2021
Merged

Upgrade stable Rust to 1.52 version #199

merged 7 commits into from
May 12, 2021

Conversation

alexlapa
Copy link
Collaborator

@alexlapa alexlapa commented May 10, 2021 •
edited by tyranron
Loading

Synopsis

Rust v1.52 is out, let's upgrade.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@alexlapa alexlapa added enhancement Improvement of existing features or bugfix k::toolchain Related to project toolchain k::refactor Refactoring, technical debt elimination and other improvements of existing code base labels May 10, 2021
@alexlapa alexlapa added this to the 0.3.0 milestone May 10, 2021
@alexlapa alexlapa self-assigned this May 10, 2021
@alexlapa
Copy link
Collaborator Author

alexlapa commented May 10, 2021 •
edited by tyranron
Loading

FMC:

Upgrade stable Rust to 1.52 version (#199)

- update and upgrade outdated Cargo deps
- upgrade to 'tokio' 1.0 and 'actix-web' 4.0 ecosystem
- make Clippy happy with new lints
- satisfy rustdoc::private_intra_doc_links lint

Additionally:
- upgrade Chrome to 90.0 version for E2E tests
- upgrade Firefox to 88.0.1 version for E2E tests

@alexlapa alexlapa marked this pull request as ready for review May 10, 2021 11:49
@alexlapa alexlapa requested a review from tyranron May 10, 2021 11:50
tyranron
tyranron approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexlapa I've done the upgrade mostly, but there are still some failing tests. Please, fix them before merge.

@tyranron tyranron changed the title Draft: Upgrade stable Rust to 1.52 version Upgrade stable Rust to 1.52 version May 12, 2021
@alexlapa alexlapa merged commit 9e3fdce into master May 12, 2021
@alexlapa alexlapa deleted the upgrade-rust-to-1-52 branch May 12, 2021 14:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@alexlapa alexlapa

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::toolchain Related to project toolchain
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexlapa @tyranron