Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPython 3.12 support, drop 3.7 #405

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

trappitsch
Copy link
Contributor

Add support and testing for py3.12, drop 3.7 since EOL. Change a test to assert_has_calls, since has_calls seems to be depreciated in 3.12.

Note: There are a few more depreciation warnings that need to be taken care of. However, this should be fixed in a separate PR.

Add support and testing for py3.12, drop 3.7 since EOL.
Change a test to `assert_has_calls`, since `has_calls` seems to be depreciated in 3.12.
Copy link

codecov bot commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (207131b) 99.03% compared to head (2bec651) 99.03%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #405   +/-   ##
=======================================
  Coverage   99.03%   99.03%           
=======================================
  Files          88       88           
  Lines        8977     8994   +17     
=======================================
+ Hits         8890     8907   +17     
  Misses         87       87           
Flag Coverage Δ
unittests 99.03% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trappitsch trappitsch mentioned this pull request Jan 28, 2024
Copy link
Contributor

@scasagrande scasagrande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all lgtm!

@scasagrande scasagrande merged commit f9aecf1 into instrumentkit:main Jan 29, 2024
11 checks passed
@trappitsch trappitsch deleted the python_312 branch January 29, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants