Increase code coverage on bootstrap levels #57
Conversation
jcsmorais
commented
Dec 18, 2013
jcsmorais
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| // FIXME: need to translate sugar db types to doctrine db types | ||
| // we're currently only supporting mysql | ||
| if ($config['dbconfig']['db_type'] === 'mysql') { | ||
| $config['dbconfig']['db_type'] = 'pdo_mysql'; |
There was a problem hiding this comment.
The list of available ones is here:
http://docs.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/configuration.html#driver
Also, we know the ones that Sugar supports, so we can easily do a mapping and have support for them all, since this is only to confirm connection. DB2 isn't yet fully supported by Doctrine, but people are already working on fixing bugs (doctrine/dbal#447) on latest versions so I think we can bet on this.
There was a problem hiding this comment.
Yeah, I know that, though I would rather postpone this and move other features forward instead.
What I mean is, we're mostly working with mysql so it is easier to add support for it first since we can test it right away. In my opinion, if down the road there's a need to add support for others we can do it on a separate PR while testing those properly as well.
Agree?
Increase code coverage on bootstrap levels
