Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change authentication success page more descriptive #312

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Conversation

int128
Copy link
Owner

@int128 int128 commented Jun 21, 2020

This will change the success page more descriptive.

screenshot

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2020

Codecov Report

Merging #312 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage   72.37%   72.40%   +0.03%     
==========================================
  Files          20       20              
  Lines         713      714       +1     
==========================================
+ Hits          516      517       +1     
  Misses        130      130              
  Partials       67       67              
Impacted Files Coverage Δ
pkg/usecases/authentication/authcode_browser.go 64.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e27385...621ec19. Read the comment docs.

@int128 int128 merged commit 77a6b91 into master Jun 23, 2020
@int128 int128 deleted the success-page branch June 23, 2020 06:01
@jetersen
Copy link

Thanks, this is awesome 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants