Added flag to let user set redirect uri for authcode-keyboard #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@int128 would it be possible to get a review of this PR? |
|
I need this update for get the OIDC token from server that can't open browser to process your workflow. |
Merged
int128
approved these changes
Jun 23, 2023
There was a problem hiding this comment.
@rnikoopour Thank you for your great contribution! Looks good.
I'd like to suggest some refactoring as #951.
Please let me know if you have any comment on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables users to redirect the auth code to an endpoint they control to present it to the user. This allows
authcode-keyboardto not only supporturn:ietf:wg:oauth:2.0:oob. This allows IDPs that do not support that URI to get auth codes.