Added detection of "*" to enable opening of multi-file datasets #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for putting this together, @agstephens! Sorry, I corrupted your main branch when I tried to push some changes to it. I am going to open another PR with your changes and I will ping you there |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
When
intake_esm.source._open_dataset()is called, it now looks for"*"in the path and it will choose to open the dataset withxarray.open_mfdataset()instead ofxarray.open_dataset(). This allows intake records to specify a glob pattern rather than an exact path.Related issue number
#385
Some tests have been added in:
tests/test_source.py. All the tests still run in my sandbox.Checklist