Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve search with derived variables #428

Merged
merged 3 commits into from Jan 11, 2022
Merged

Improve search with derived variables #428

merged 3 commits into from Jan 11, 2022

Conversation

aulemahal
Copy link
Contributor

@aulemahal aulemahal commented Dec 21, 2021 •
edited

Change Summary

  • Non-variable query terms are repeated when searching the catalog with dependent variables.
  • When dependent variables are found, they are added to the variable list that may be sent to the "requested_variables" attribute of the "child" catalog.
  • The derived variable registry is only subsetted if variables were requested in the query. Otherwise, the full DVR is given to the "child" catalog.

Related issue number

Fixes #427

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

I'll try to find time to add unit tests, but that might be in january, sorry. I wanted to open the PR first to see people's thoughts.

@andersy005
Copy link
Member

Many thanks for this fix!

I'll try to find time to add unit tests, but that might be in january, sorry. I wanted to open the PR first to see people's thoughts.

No worries. Take your time... Many thanks for this fix/PR!

andersy005
andersy005 approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great 👍🏽 , @aulemahal! Thank you for your contribution 🎉

@andersy005
Copy link
Member

The upstream-dev CI failures are unrelated. I fixed them in #432

@andersy005 andersy005 merged commit 699c00b into intake:main Jan 11, 2022
@andersy005 andersy005 added the enhancement Issues that are found to be a reasonable candidate feature additions label Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersy005 andersy005 andersy005 approved these changes

Assignees
No one assigned
Labels
bug-fix enhancement Issues that are found to be a reasonable candidate feature additions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Searching with derived variables is broken
2 participants
@aulemahal @andersy005